[4.19] Storage: replace artifactory with DataSource in test_golden_image#4384
Open
kshvaika wants to merge 7 commits intoRedHatQE:cnv-4.19from
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
requested review from
Ahmad-Hafe,
dalia-frank,
dshchedr,
duyanyan,
geetikakay,
josemacassan,
jpeimer and
rnetser
…edHatQE#4095) This PR replaces the use of the artifactory with the DataSource Fedora in tests/storage/golden_image/test_golden_image.py https://issues.redhat.com/browse/CNV-79290 There is another PR RedHatQE#3892 that contains changes used by this PR: - moving fedora_data_source_scope_module fixture from tests/storage/cdi_clone/conftest.py to tests/storage/conftest.py - adding a separate function get_dv_size_from_datasource to get the size from a DataSource (the function is placed in tests/storage/utils.py since it will be used both in tests/storage/golden_image/test_golden_image.py and tests/storage/restricted_namespace_cloning (RedHatQE#3892)) <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Tests** * Updated storage tests to use dynamic data sources instead of hardcoded image URLs and sizes. * Added support for Fedora OS flavor in test fixtures alongside existing RHEL configurations. * Refactored golden image tests to use data source references for DataVolume creation, providing more flexible and maintainable test scenarios. * Improved test utility functions to support dynamic size extraction from data sources. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
kshvaika
force-pushed
the
419_use_datasource_instead_of_artifactory_in_test_golden_image
branch
from
c23e13c to
eaa2031
Compare
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
Author
|
/build-and-push-container |
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4384 published |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
@rnetser It will require backporting a wrapper PR, and an openshift-virtualization-tests PR, both of which will require thorough verification. I don't think our team has the capacity to do it all the way down to 4.12 |
Contributor
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4441. Overlapping filestests/storage/conftest.py |
Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
Signed-off-by: Kate Shvaika <kshvaika@redhat.com>
openshift-virtualization-qe-bot-5
requested review from
ema-aka-young and
josemacassan
openshift-virtualization-qe-bot-5
requested review from
acinko-rh,
jpeimer and
rnetser
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4384 published |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Unrecoverable error: Failed to clone repository 🏁 Script executed: Length of output: 3060 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Manual cherry-pick: #4095
More details:
Since there is no source_ref support in openshift-python-wrapper 4.19.0 and cnv-4.19 and earlier
https://github.com/RedHatQE/openshift-virtualization-tests/blob/cnv-4.19/utilities/storage.py#L107
https://github.com/RedHatQE/openshift-python-wrapper/blob/v4.19/ocp_resources/datavolume.py#L14
this PR adds create_dv_with_source_ref
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: